Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve life cycle hooks typings #8652

Merged

Conversation

jantimon
Copy link
Contributor

@jantimon jantimon commented Nov 25, 2022

Description

I would like to prepare a PR for #8643.
Right now the life cycle hooks are using generics and reducers which kind of blocks an easy implementation.

Therefore I removed the reducer and the generic type.

Related #8643

Type of change

Please delete options that are not relevant.

  • Internal Typings

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

🦋 Changeset detected

Latest commit: b1cb681

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@graphql-codegen/cli Patch
@graphql-codegen/plugin-helpers Major
@graphql-cli/codegen Patch
@graphql-codegen/core Patch
@graphql-codegen/testing Patch
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/add Patch
@graphql-codegen/fragment-matcher Patch
@graphql-codegen/introspection Patch
@graphql-codegen/schema-ast Patch
@graphql-codegen/time Patch
@graphql-codegen/visitor-plugin-common Patch
@graphql-codegen/client-preset Patch
@graphql-codegen/gql-tag-operations-preset Patch
@graphql-codegen/graphql-modules-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/plenty-bottles-prove.md Outdated Show resolved Hide resolved
packages/graphql-codegen-cli/src/hooks.ts Outdated Show resolved Hide resolved
jantimon and others added 2 commits November 28, 2022 19:02
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
@jantimon jantimon requested review from saihaj and removed request for charlypoly and n1ru4l November 28, 2022 18:21
@saihaj
Copy link
Collaborator

saihaj commented Dec 6, 2022

sorry for the delay here

@saihaj saihaj merged commit c802a0c into dotansimha:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants