Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: remove hooks reducer #8661

Conversation

jantimon
Copy link
Contributor

@jantimon jantimon commented Nov 29, 2022

For an easier review #8652 was split into two PRs.

This is the second part of #8652. It's a small refactoring to replace an entire reducer with 3 lines of code.

Please wait with a review after #8652 was merged and this PR was rebased on top of master.

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2022

🦋 Changeset detected

Latest commit: 169127a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-codegen/cli Patch
@graphql-codegen/plugin-helpers Patch
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saihaj
Copy link
Collaborator

saihaj commented Dec 6, 2022

@jantimon can you rebase this PR?

@jantimon
Copy link
Contributor Author

jantimon commented Dec 6, 2022

@saihaj done :)

@saihaj saihaj merged commit f79a00e into dotansimha:master Dec 6, 2022
@jantimon
Copy link
Contributor Author

jantimon commented Dec 6, 2022

thanks for merging

@jantimon jantimon deleted the features/remove-hook-reducer branch December 6, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants