Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: top level ts-node registration bug #8590

Merged
merged 3 commits into from Nov 30, 2022
Merged

fix: top level ts-node registration bug #8590

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f96263
fix: top level ts-node registration bug
Diizzayy Nov 8, 2022
6b49fbe
chore: add changeset
Diizzayy Nov 8, 2022
47282af
Apply suggestions from code review
charlypoly Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silent-singers-cover.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'@graphql-codegen/cli': major
charlypoly marked this conversation as resolved.
Show resolved Hide resolved
---

register TypeScriptLoader when needed
5 changes: 2 additions & 3 deletions packages/graphql-codegen-cli/src/config.ts
View file
Open in desktop
Expand Up @@ -21,9 +21,6 @@ import { createHash } from 'crypto';

const { lstat } = promises;

// #8437: conflict with `graphql-config` also using TypeScriptLoader(), causing a double `ts-node` register.
const tsLoader = TypeScriptLoader({ transpileOnly: true });

export type CodegenConfig = Types.Config;

export type YamlCliFlags = {
Expand Down Expand Up @@ -77,6 +74,8 @@ function customLoader(ext: 'json' | 'yaml' | 'js' | 'ts') {
}

if (ext === 'ts') {
// #8437: conflict with `graphql-config` also using TypeScriptLoader(), causing a double `ts-node` register.
charlypoly marked this conversation as resolved.
Show resolved Hide resolved
const tsLoader = TypeScriptLoader({ transpileOnly: true });
return tsLoader(filepath, content);
}
}
Expand Down