Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: top level ts-node registration bug #8590

Merged
merged 3 commits into from Nov 30, 2022
Merged

Conversation

Diizzayy
Copy link
Contributor

@Diizzayy Diizzayy commented Nov 8, 2022

Description

This PR simply averts from using a top level variable for the TypeScriptLoader to prevent the unnecessary early registration of ts-node

Related #8588

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

🦋 Changeset detected

Latest commit: 47282af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/cli Minor
@graphql-cli/codegen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@charlypoly charlypoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Diizzayy, I've updated the changeset to minor since we use minor for breaking changes and major for big releases.

Besides that, I conducted some manual QA and did not found any regression, testing with the following config:

import { CodegenConfig } from "@graphql-codegen/cli";
import dotenv from "dotenv";
import { schemaPath } from "./test";

dotenv.config();

const config: CodegenConfig = {
  schema: schemaPath,
  documents: [process.env.DOCS!],
  generates: {
    "types.ts": {
      plugins: ["typescript", "typescript-operations"],
    },
  },
};

export default config;

Looks good to me, thanks! ⚡

@charlypoly charlypoly merged commit 2c7fa51 into dotansimha:master Nov 30, 2022
@Diizzayy
Copy link
Contributor Author

Besides that, I #8665 and did not found any regression, testing with the following config

@charlypoly Happy to hear! Thanks again for taking the time to have another look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants