Fixes parenthesis when \n is involved

[Warxcell]

JSON_CONTAINS(p.state, :positive_value, :ordered_state) = :positive_value 
OR 
JSON_CONTAINS(p.state, :positive_value, :completed_state) = :positive_value)

when we have OR like that (without space before OR) - it doesn't add parenthesis.

[greg0ire]

I guess there is the same issue with tabulations, right?

[Warxcell]

I guess there is the same issue with tabulations, right?

I don't know. Who uses tabs on queries anyways?

EDIT: Just tried it out, my IDE converts automatically tabs to multiple spaces..

[greg0ire]

Yeah, but maybe str_replace is faster. If we will use RegEx, I can just use preg_match and not replace anything.

Probably, but here I don't think we are in the hot path: we are in dql parsing which:

• is cached
• does not happen a lot (a few queries vs other code that applies on every row of the result set)

[Warxcell]

• is cached
• does not happen a lot (a few queries vs other code that applies on every row of the result set)

I think it's not the actual flow.

This is QueryBuilder, which builds DQL which is then parsed and after that cached.
So next time we have again QueryBuilder, which builds DQL, (skips parsing, because it's cached), then it's returned by cache.

But yeah, 30-40 preg_matches more (how many QB can have a single page?) - won't be anything significant.

[greg0ire]

Hmmm yes I think you're right, it's probably executed every time indeed 👍
Anyway, not significant at all IMO.

[SenseException]

The pattern is not a expensive one. I think this should be fine.

[greg0ire]

Thanks @Warxcell ! I squashed your commits because the first one and the last one really should, and although you made an argument for squashing in another PR, in this case it's unlikely to apply.