Return case insensitive check

[DmitriiBezborodnikov]

Return insensitive check after #8453

Problem: ->andWhere("u.name = ?1 or u.username = ?1"); did not wrap part in parenthesis when or or and was written in lowercase anymore. It still worked for uppercase OR and AND.

Fixes #8595

[greg0ire]

@Warxcell please review

[Warxcell]

Yeah, seems we missed the case with lower case keywords. And there were no tests that could catch it. :(

[greg0ire]

I tried restoring the source code and running the test suite, and the test suite did not fail, because the test class, is not suffixed with Test 🙈

[Warxcell]

I tried restoring the source code and running the test suite, and the test suite did not fail, because the test class, is not suffixed with Test

./vendor/bin/phpunit tests/Doctrine/Tests/ORM/Functional/QueryBuilderParenthesis.php
PHPUnit 9.5.2 by Sebastian Bergmann and contributors.

.. 2 / 2 (100%)

Time: 00:00.063, Memory: 12.00 MB

OK (2 tests, 4 assertions)

So phpunit have different behaviour depending on how you run it? That's bad :( It should tell me that this is not valid test IMO.

[greg0ire]

Yup… kinda weird that my last commit does not result in an increase in coverage.

I have to go for now but I've started working on a find expression to find more test cases like this: find tests -type f -name '*.php' -not \( -name '*Test.php' -o -wholename 'tests/Doctrine/Tests/Models/*' -o -wholename 'tests/Doctrine/Tests/Proxies/__CG__*' -o -wholename 'tests/Doctrine/Tests/ORM/Tools/Export/*' \)

UPD: here is a legible input with a legible output:

find tests -type f -name '*.php' -not \( -name '*Test.php' \
 -o -wholename 'tests/Doctrine/Tests/Models/*' \
 -o -wholename 'tests/Doctrine/Tests/Proxies/__CG__*' \
 -o -wholename 'tests/Doctrine/Tests/ORM/Tools/Export/*' \
 -o -wholename 'tests/Doctrine/Tests/ORM/Mapping/*.php' \
 -o -wholename 'tests/Doctrine/Performance/*'\
 -o -wholename 'tests/Doctrine/Tests/Mocks/*'\
 -o -name '*TestCase.php'\
 -o -name '*Type.php' \)
tests/Doctrine/Tests/VerifyDeprecations.php
tests/Doctrine/Tests/TestUtil.php
tests/Doctrine/Tests/IterableTester.php
tests/Doctrine/Tests/TestInit.php
tests/Doctrine/Tests/ORM/Functional/ClassTableInheritanceTest2.php
tests/Doctrine/Tests/ORM/Functional/Ticket/Ticket69.php
tests/Doctrine/Tests/ORM/Functional/Locking/LockAgentWorker.php
tests/Doctrine/Tests/EventListener/CacheMetadataListener.php
tests/Doctrine/Tests/DbalTypes/CustomIdObject.php

[greg0ire]

I don't reproduce the test failure locally 😬

[greg0ire]

Let's treat that one separately, I'll open another PR for it.

[greg0ire]

Thanks @DmitriiBezborodnikov !