Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecation about PHPUnit annotations #8070

Merged

Conversation

greg0ire
Copy link
Member

These changes have been done using Rector, this might not result in the
best placement for method calls, but it is not worse than the current
situation.

I used the configuration documented at
https://github.com/rectorphp/rector/blob/b398e8740c3619525061350d4d4e1bca20dabea9/docs/HowItWorks.md#221-order-of-rectors

Fixes #8069

These changes have been done using Rector, this might not result in the
best placement for method calls, but it is not worse than the current
situation.

I used the configuration documented at
https://github.com/rectorphp/rector/blob/b398e8740c3619525061350d4d4e1bca20dabea9/docs/HowItWorks.md#221-order-of-rectors

Fixes doctrine#8069
@greg0ire greg0ire force-pushed the address-phpunit-annotation-deprecation branch from 3e5ee07 to e613844 Compare March 15, 2020 19:45
@greg0ire greg0ire requested a review from beberlei March 15, 2020 19:56
@beberlei beberlei merged commit 3c91792 into doctrine:2.8.x Mar 16, 2020
@greg0ire greg0ire deleted the address-phpunit-annotation-deprecation branch March 16, 2020 18:10
@greg0ire greg0ire linked an issue Mar 16, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert PHPUnit @expectedException into method call
2 participants