Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert PHPUnit @expectedException into method call #8069

Closed
beberlei opened this issue Mar 15, 2020 · 4 comments · Fixed by #8070
Closed

Convert PHPUnit @expectedException into method call #8069

beberlei opened this issue Mar 15, 2020 · 4 comments · Fixed by #8070
Assignees
@greg0ire
Labels
Hacktoberfest Good issue for participating in Hacktoberfest Improvement
Milestone
2.8.0

Comments

@beberlei
Copy link
Member

In #8050 we found usage of a deprecated PHPUnit functionality. We should move all @expectedException and @expectedExceptionMessage inline into the code to their respective method calls.

Is there a Rector script for this?
@beberlei beberlei added this to the 2.8.0 milestone Mar 15, 2020
@beberlei beberlei added the Hacktoberfest Good issue for participating in Hacktoberfest label Mar 15, 2020
@greg0ire
Copy link
Member

greg0ire commented Mar 15, 2020 •
edited

Looks like it: https://github.com/rectorphp/rector/blob/b398e8740c3619525061350d4d4e1bca20dabea9/docs/HowItWorks.md#221-order-of-rectors

@beberlei
Copy link
Member Author

@greg0ire have a take at it if you want :)

@greg0ire
Copy link
Member

I'm on it!

greg0ire added a commit to greg0ire/doctrine-orm that referenced this issue Mar 15, 2020
@greg0ire
Address deprecation about PHPUnit annotations
3e5ee07 
These changes have been done using Rector, this might not result in the
best placement for method calls, but it is not worse than the current
situation.

I used the configuration documented at
https://github.com/rectorphp/rector/blob/b398e8740c3619525061350d4d4e1bca20dabea9/docs/HowItWorks.md#221-order-of-rectors

Fixes doctrine#8069
@greg0ire greg0ire mentioned this issue Mar 15, 2020
Merged
greg0ire added a commit to greg0ire/doctrine-orm that referenced this issue Mar 15, 2020
@greg0ire
Address deprecation about PHPUnit annotations
e613844 
These changes have been done using Rector, this might not result in the
best placement for method calls, but it is not worse than the current
situation.

I used the configuration documented at
https://github.com/rectorphp/rector/blob/b398e8740c3619525061350d4d4e1bca20dabea9/docs/HowItWorks.md#221-order-of-rectors

Fixes doctrine#8069
@greg0ire greg0ire self-assigned this Mar 15, 2020
beberlei pushed a commit that referenced this issue Mar 16, 2020
@greg0ire
Address deprecation about PHPUnit annotations (#8070)
3c91792 
These changes have been done using Rector, this might not result in the
best placement for method calls, but it is not worse than the current
situation.

I used the configuration documented at
https://github.com/rectorphp/rector/blob/b398e8740c3619525061350d4d4e1bca20dabea9/docs/HowItWorks.md#221-order-of-rectors

Fixes #8069
@beberlei
Copy link
Member Author

Fixed by #8070

@greg0ire greg0ire linked a pull request Mar 16, 2020 that will close this issue
Address deprecation about PHPUnit annotations #8070
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg0ire greg0ire

Labels
Hacktoberfest Good issue for participating in Hacktoberfest Improvement
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Address deprecation about PHPUnit annotations greg0ire/doctrine-orm
2 participants
@beberlei @greg0ire