Remove code compensating for a schema comparison flaw #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
changed the title
This code was relevant before the improvement in doctrine#4746 was implemented. The new comparator API is enforced in doctrine#4771. Now, the comparator will not produce a false-positive diff which is enforced by the new test.
morozov
force-pushed
the
oracle-alter-table-cleanup
branch
from
771d873
to
c20d091
Compare
greg0ire
approved these changes
Aug 26, 2022
This was referenced Aug 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was relevant before the improvement in #4746 was implemented. The new comparator API is enforced in #4771.
Now, the comparator will not produce a false-positive diff which is enforced by the new test.