Remove redundant condition from DB2 platform #5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
Aug 26, 2022
| @@ -610,10 +610,6 @@ public function getAlterTableSQL(TableDiff $diff) | |||
| $columnDiff->column->getQuotedName($this), | |||
| $this->getColumnComment($columnDiff->column) | |||
| ); | |||
|
|
|||
| if (count($columnDiff->changedProperties) === 1) { | |||
There was a problem hiding this comment.
The real reason for this change is to get rid of direct access to ColumnDiff::$changedProperties and enable further refactoring of the schema comparison API.
#5620 was implemented for the same purpose as well. More changes are to follow.
greg0ire
approved these changes
Aug 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively, it (poorly) duplicates the following one:
dbal/src/Platforms/DB2Platform.php
Lines 719 to 725 in 5f83788
If the provided set of changed properties doesn't warrant a certain schema change,
DB2Platform::getAlterColumnClausesSQL()will produce an empty array of SQL statements.