Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated QueryBuilder methods and constants #5553

Merged
merged 3 commits into from Jul 31, 2022
Merged

Remove deprecated QueryBuilder methods and constants #5553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8b5aa2
Remove QueryBuilder::getType() and ::getState()
morozov Jul 30, 2022
1a15fb8
Rework tracking state in QueryBuilder
morozov Jul 30, 2022
e2c6f56
Represent query type as enum in QueryBuilder
morozov Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 15 additions & 2 deletions UPGRADE.md
View file
Open in desktop
Expand Up @@ -289,9 +289,22 @@ DBAL is now tested only with SQL Server 2017 and newer.

The `Statement::execute()` method has been marked private.

## BC BREAK: Removed `QueryBuilder::execute()`.
## BC BREAK: Removed `QueryBuilder` methods and contstants.

The `QueryBuilder::execute()` method has been removed.
The following `QueryBuilder` methods have been removed:

1. `execute()`,
2. `getState()`,
3. `getType()`.

The following `QueryBuilder` constants have been removed:

1. `SELECT`,
2. `DELETE`,
3. `UPDATE`,
4. `INSERT`,
5. `STATE_DIRTY`,
6. `STATE_CLEAN`.

## BC BREAK: Removed the `Constraint` interface.

Expand Down
14 changes: 0 additions & 14 deletions psalm.xml.dist
View file
Open in desktop
Expand Up @@ -32,27 +32,13 @@
<file name="src/Driver/OCI8/ConvertPositionalToNamedPlaceholders.php"/>
</errorLevel>
</ConflictingReferenceConstraint>
<DeprecatedConstant>
<errorLevel type="suppress">
<!--
TODO: remove in 4.0.0
-->
<file name="src/Query/QueryBuilder.php"/>
<file name="tests/Query/QueryBuilderTest.php"/>
</errorLevel>
</DeprecatedConstant>
<DeprecatedMethod>
<errorLevel type="suppress">
<!--
This suppression should be removed after 2022
See https://github.com/doctrine/dbal/pull/4317
-->
<file name="tests/Functional/LegacyAPITest.php"/>
<!--
TODO: remove in 4.0.0
-->
<referencedMethod name="Doctrine\DBAL\Query\QueryBuilder::getState"/>
<referencedMethod name="Doctrine\DBAL\Query\QueryBuilder::getType"/>
</errorLevel>
</DeprecatedMethod>
<DocblockTypeContradiction>
Expand Down