Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated QueryBuilder methods and constants #5553

Merged
merged 3 commits into from Jul 31, 2022
Merged

Remove deprecated QueryBuilder methods and constants #5553

merged 3 commits into from Jul 31, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 30, 2022 •
edited

  1. Simplify handling query builder state by getting rid of the $state property and the corresponding constants.
  2. Represent query type as @internal enum.

The removed method and constants were deprecated in #5551.

@morozov morozov added this to the 4.0.0 milestone Jul 30, 2022
@morozov morozov marked this pull request as ready for review July 30, 2022 20:24
@morozov morozov merged commit 24527b3 into doctrine:4.0.x Jul 31, 2022
@morozov morozov deleted the query-builder-enums branch July 31, 2022 15:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
BC Break PHP QueryBuilder
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @derrabus