Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4613] Use utf8mb4 instead of utf8 for testing connection charset #4625

Merged
merged 1 commit into from Apr 29, 2021
Merged

[GH-4613] Use utf8mb4 instead of utf8 for testing connection charset #4625

merged 1 commit into from Apr 29, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 29, 2021

Q A
Type improvement
BC Break no

This is a backport of #4614.

@morozov morozov linked an issue Apr 29, 2021 that may be closed by this pull request
PrimaryReadReplicaConnectionTest::testInheritCharsetFromPrimary() is failing on CI #4613
Closed
@morozov morozov requested a review from greg0ire April 29, 2021 16:04
@morozov morozov merged commit a8cf0ed into doctrine:2.13.x Apr 29, 2021
@morozov morozov deleted the issues/4613 branch April 29, 2021 16:46
@greg0ire greg0ire added this to the 2.13.2 milestone Apr 30, 2021
@morozov morozov mentioned this pull request May 2, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Character Encoding Connections MySQL Test Suite
Projects
None yet
Milestone
2.13.2
Development

Successfully merging this pull request may close these issues.

PrimaryReadReplicaConnectionTest::testInheritCharsetFromPrimary() is failing on CI
2 participants
@morozov @greg0ire