Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimaryReadReplicaConnectionTest::testInheritCharsetFromPrimary() is failing on CI #4613

Closed
morozov opened this issue Apr 20, 2021 · 1 comment · Fixed by #4614 or #4625
Closed

PrimaryReadReplicaConnectionTest::testInheritCharsetFromPrimary() is failing on CI #4613

morozov opened this issue Apr 20, 2021 · 1 comment · Fixed by #4614 or #4625
Labels
Character Encoding Connections MySQL Test Suite
Milestone
3.1.1

Comments

@morozov
Copy link
Member

morozov commented Apr 20, 2021 •
edited

The failure looks like the following:

1) Doctrine\DBAL\Tests\Functional\PrimaryReadReplicaConnectionTest::testInheritCharsetFromPrimary
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'utf8'
+'utf8mb3'

Note that as of MySQL 8.0, the utf8 character set is an alias for utf8mb3.
morozov added a commit to morozov/dbal that referenced this issue Apr 20, 2021
@morozov
[doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection …
b44a212 
…charset
@morozov morozov mentioned this issue Apr 20, 2021
Merged
morozov added a commit to morozov/dbal that referenced this issue Apr 20, 2021
@morozov
[doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection …
c459948 
…charset
morozov added a commit to morozov/dbal that referenced this issue Apr 20, 2021
@morozov
[doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection …
8f59014 
…charset
@morozov morozov added this to the 3.1.1 milestone Apr 20, 2021
morozov added a commit that referenced this issue Apr 21, 2021
@morozov
Merge pull request #4614 from morozov/issues/4613
7dc3905 
[GH-4613] Use utf8mb4 instead of utf8 for testing connection charset
morozov added a commit to morozov/dbal that referenced this issue Apr 29, 2021
@morozov
[doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection …
67ec723 
…charset
@morozov morozov linked a pull request Apr 29, 2021 that will close this issue
[GH-4613] Use utf8mb4 instead of utf8 for testing connection charset #4625
Merged
morozov added a commit to morozov/dbal that referenced this issue Apr 29, 2021
@morozov
[doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection …
bafa3e3 
…charset
morozov added a commit that referenced this issue Apr 29, 2021
@morozov
Merge pull request #4625 from morozov/issues/4613
a8cf0ed 
[GH-4613] Use utf8mb4 instead of utf8 for testing connection charset
derrabus added a commit to derrabus/dbal that referenced this issue May 2, 2021
@derrabus
Merge branch '2.13.x' into 3.1.x
479d08d 
* 2.13.x:
  Support Doctrine Cache 2
  Display metrics of 3.1 instead of 3.0
  [doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection charset
derrabus added a commit to derrabus/dbal that referenced this issue May 2, 2021
@derrabus
Merge branch '2.13.x' into 3.1.x
3ebe5d7 
* 2.13.x:
  Support Doctrine Cache 2
  Display metrics of 3.1 instead of 3.0
  [doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection charset
derrabus added a commit to derrabus/dbal that referenced this issue May 2, 2021
@derrabus
Merge branch '3.1.x' into 3.2.x
3da4583 
* 3.1.x:
  Support Doctrine Cache 2
  Display metrics of 3.1 instead of 3.0
  [doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection charset
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '3.1.x' into merge/3.1.x-in-3.2.x
f36aead 
* 3.1.x:
  Allow Symfony 6
  Update versions for default branch
  Address class rename in the docs
  Support Doctrine Cache 2
  Display metrics of 3.1 instead of 3.0
  [doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection charset
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '3.1.x' into merge/3.1.x-in-3.2.x
326cf4c 
* 3.1.x:
  Allow Symfony 6
  Update versions for default branch
  Address class rename in the docs
  Support Doctrine Cache 2
  Display metrics of 3.1 instead of 3.0
  [doctrineGH-4613] Use utf8mb4 instead of utf8 for testing connection charset
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Character Encoding Connections MySQL Test Suite
Projects
None yet
Milestone
3.1.1
1 participant
@morozov