New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated schema- and namespace-related APIs #4577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in case the answer to my question is no.
*/ | ||
public function getExistingSchemaSearchPaths(): array | ||
protected function getExistingSchemaSearchPaths(): array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these also become final?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of this API is not really clear to me: there's a single use case which uses only the first element of the path:
dbal/src/Schema/PostgreSQLSchemaManager.php
Lines 177 to 180 in d19875a
protected function _getPortableTableDefinition(array $table): string | |
{ | |
$schemas = $this->getExistingSchemaSearchPaths(); | |
$firstSchema = array_shift($schemas); |
So I'd expect some more rework here in the future.
But yeah, final
for the wrapper makes sense regardless. I'd leave the "determine" method as is (in case if somebody hacks their own logic in there).
…eExistingSchemaSearchPaths()
See #4503.