Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated schema- and namespace-related APIs #4577

Merged
merged 2 commits into from Apr 3, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 2, 2021

Q A
Type improvement
BC Break yes

See #4503.

@morozov morozov linked an issue Apr 2, 2021 that may be closed by this pull request
@morozov morozov changed the title Remove deprecated in schema- and namespace-related APIs Remove deprecated schema- and namespace-related APIs Apr 2, 2021
@morozov morozov marked this pull request as ready for review April 2, 2021 19:33
@morozov morozov requested a review from greg0ire April 2, 2021 19:33
@morozov morozov added this to the 4.0.0 milestone Apr 2, 2021
greg0ire
greg0ire previously approved these changes Apr 3, 2021
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in case the answer to my question is no.

*/
public function getExistingSchemaSearchPaths(): array
protected function getExistingSchemaSearchPaths(): array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these also become final?

Copy link
Member Author

@morozov morozov Apr 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this API is not really clear to me: there's a single use case which uses only the first element of the path:

protected function _getPortableTableDefinition(array $table): string
{
$schemas = $this->getExistingSchemaSearchPaths();
$firstSchema = array_shift($schemas);

So I'd expect some more rework here in the future.

But yeah, final for the wrapper makes sense regardless. I'd leave the "determine" method as is (in case if somebody hacks their own logic in there).

@morozov morozov merged commit ac2763f into doctrine:4.0.x Apr 3, 2021
@morozov morozov deleted the issues/4503 branch April 3, 2021 16:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent SchemaManager API across platforms
2 participants