Inconsistent SchemaManager API across platforms

[morozov]

Some ShemaManager subclasses have public methods that don't exist in the base class, e.g. PostgreSQLSchemaManager#getSchemaNames().

The downside of this is that it's impossible to analyze such code statically:

DriverManager::getConnection($params)->getSchemaManager()->getSchemaNames();

1. If your code works only with PostgreSQL, you'll need to make a type assertion before calling the method:

   dbal/tests/Doctrine/Tests/DBAL/Functional/Schema/PostgreSqlSchemaManagerTest.php

   Line 58 in ffbfa1c

   assert($this->schemaManager instanceof PostgreSqlSchemaManager);

2. If your code is supposed to work with multiple platforms, then you'll have to implement the API missing in other platforms yourself which is a result of leaky abstraction.

Not sure if it's possible to enforce it via automation, but for the classes that are instantiated dynamically (drivers, platforms) we should be aiming towards not allowing the methods that aren't described in the base class or implemented interface(s).

So far, the following can be improved:

1. PostgreSQLSchemaManager#getSchemaNames() – could be declared in the base class with an empty implementation.
2. PostgreSQLSchemaManager#getExistingSchemaSearchPaths() , PostgreSQLSchemaManager#determineExistingSchemaSearchPaths(), OracleSchemaManager#dropAutoincrement()– used only internally by a protected method. Could be marked internal and then made protected in the next major.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.