Address deprecations from persistence #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A backwards-compatibility layer has been added to persistence to help consumers move to the new namespacing. It is based on class aliases, which means the type declaration changes should not be a BC-break: types are the same. See doctrine/persistence#71 This means: - using the new namespaces - adding autoload calls for new types to types that may be extended and use persistence types in type declarations of non-constructor methods, so that signature compatibility is recognized by old versions of php. More details on this at https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf
|
Seems like this has to do with doctrine/orm#7079 |
We use SQLite in tests, and that platform does not support schemas.
This was referenced Dec 31, 2019
jwage
approved these changes
Jan 4, 2020
ostrolucky
reviewed
Jan 4, 2020
ostrolucky
approved these changes
Jan 4, 2020
This was referenced Jan 4, 2020
shadowhand
reviewed
Jan 16, 2020
| @@ -139,3 +140,5 @@ public function purge() | |||
| */ | |||
| abstract public function execute(array $fixtures, $append = false); | |||
| } | |||
|
|
|||
| interface_exists(ObjectManager::class); | |||
There was a problem hiding this comment.
Why is this line included? It appears a couple of other places too, and seems like debugging code left behind.
There was a problem hiding this comment.
It really isn't. If you want to know, follow the link in the PR body / the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backwards-compatibility layer has been added to persistence to help
consumers move to the new namespacing. It is based on class aliases,
which means the type declaration changes should not be a BC-break: types
are the same.
See doctrine/persistence#71
This means:
use persistence types in type declarations of non-constructor methods,
so that signature compatibility is recognized by old versions of php.
More details on this at
https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf