Add correct return type to DependentFixtureInterface::getDependencies

[ruudk]

This makes it easier for PHPStan to understand what's going on.

[alcaeus]

How does PhpStorm handle the class-string type? I’m worried that it may not understand what’s going on...

[ruudk]

I checked. It just sees it as array of mixed, and that was already the case :)

[ruudk]

I'm sure PHPStorm will soon support all the new PHPStan/Psalm notations.

[alcaeus]

Great. I’ll take care of this after the holidays, as I need to check the branches and do some more work here for the persistence deprecations.

I believe this should be fixed in a patch release, would you agree?

[ruudk]

Thanks! I agree.

[ruudk]

@greg0ire Can we merge it? :)

[greg0ire]

I'm not sure: 1.3 is still maintained, isn't it affected by this too?

[ruudk]

@greg0ire Changed base branch and rebased it

[greg0ire]

Aaaaand the test fail… please cherry-pick b7532e4, that should fix it.

[ruudk]

Sorry, but that's not part of this PR. Clearly 1.3.x- branch is broken. I tried to cherry pick it but that forces me to fix a merge conflict. This such a small change, that I already spend too much time on.

[greg0ire]

Ok don't worry, I'm going to take care of fixing the branch, just leave this open.

[greg0ire]

Ok so apparently it is no longer maintained (see #335), so targeting 1.4.x was the right thing to do, sorry.

[greg0ire]

Thanks @ruudk !

[vitek-rostislav]

Hi, this made my phpstan in version 0.11.6 fail on

invalid type Doctrine\Common\DataFixtures\class

😞

Luckily, upgrading to ^0.12 version helped.