Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect schema asset filters from DBAL 2.9+ #312

Merged
merged 1 commit into from Jul 10, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jul 9, 2019

Fixes #310. This updates the ORMPurger class to no longer ignore the schemaAssetFilter configuration attribute. This can cause issues when using DoctrineBundle 1.11 and DBAL 2.9 which no longer sets a filter expression but creates a schema asset filter.

@alcaeus alcaeus added the Bug label Jul 9, 2019
@alcaeus alcaeus added this to the 1.3.2 milestone Jul 9, 2019
@alcaeus alcaeus self-assigned this Jul 9, 2019
@alcaeus alcaeus closed this Jul 9, 2019
@alcaeus alcaeus reopened this Jul 9, 2019
@alcaeus alcaeus requested a review from jwage July 9, 2019 20:16
@alcaeus alcaeus merged commit 09b1694 into doctrine:master Jul 10, 2019
@alcaeus alcaeus deleted the fix-schema-filters branch July 10, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORMPurger ignores callable schemaAssetsFilter
2 participants