Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORMPurger ignores callable schemaAssetsFilter #310

Closed
guillaumesmo opened this issue May 31, 2019 · 4 comments · Fixed by #312
Closed

ORMPurger ignores callable schemaAssetsFilter #310

guillaumesmo opened this issue May 31, 2019 · 4 comments · Fixed by #312
Assignees
@alcaeus
Labels
Bug
Milestone
1.3.2

Comments

@guillaumesmo
Copy link

guillaumesmo commented May 31, 2019 •
edited

ORMPurger completely ignores the Configuration::setSchemaAssetsFilter becauses it still relies on the deprecated setFilterSchemaAssetsExpression

With the latest Symfony DoctrineBundle, setSchemaAssetsFilter is used and deletes all schemas

See doctrine/DoctrineBundle#935
@alcaeus alcaeus added the Bug label Jul 9, 2019
@alcaeus alcaeus self-assigned this Jul 9, 2019
@alcaeus alcaeus added this to the 1.3.2 milestone Jul 9, 2019
@alcaeus alcaeus mentioned this issue Jul 9, 2019
Merged
@alcaeus
Copy link
Member

alcaeus commented Jul 9, 2019

See #312. @guillaumesmo could you let me know if this fixes your problem? Thanks!

@guillaumesmo
Copy link
Author

@alcaeus this is indeed fixed with your branch. Tested with doctrine/doctrine-bundle 1.11.2 and doctrine/data-fixtures (dev-fix-schema-filters 92c9d05)

I also double-checked it doesn't work with doctrine/doctrine-bundle 1.11.2 and doctrine/data-fixtures v1.3.1

@alcaeus
Copy link
Member

alcaeus commented Jul 10, 2019

Wonderful, thank you! I’ll tag a release soon.

@alcaeus
Copy link
Member

alcaeus commented Jul 10, 2019

1.3.2 has been released. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alcaeus alcaeus

Labels
Bug
Projects
None yet
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

Respect schema asset filters from DBAL 2.9+ alcaeus/data-fixtures
2 participants
@alcaeus @guillaumesmo