#186 check if file exists before asking for mtime #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Feb 17, 2022
|
|
||
| private static function getFileMtime(string $fileName): int | ||
| { | ||
| return file_exists($fileName) && is_file($fileName) ? filemtime($fileName) : 0; |
There was a problem hiding this comment.
Why do we need to call both file_exists and is_file?
There was a problem hiding this comment.
return file_exists($fileName) ? filemtime($fileName) : 0;should do the trick too, shouldn't it?
There was a problem hiding this comment.
The edge case that is_file checks for here is if $fileName is a directory. I guess it makes sense to return 0 in this case, but I don't know if :
- It's the focus of this PR
getFileMtime()can get called with a directory name at all
There was a problem hiding this comment.
Isn't file_exists redundant if we have is_file?
SenseException
requested changes
Feb 21, 2022
|
|
||
| private static function getFileMtime(string $fileName): int | ||
| { | ||
| return file_exists($fileName) && is_file($fileName) ? filemtime($fileName) : 0; |
There was a problem hiding this comment.
return file_exists($fileName) ? filemtime($fileName) : 0;should do the trick too, shouldn't it?
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine/annotationshandles reading annotations from eval’ed code (as in mock objects) just fine, except that it attempts to determine the modification time viaReflectionClass::getFile()which will return the file and line where theeval()happened. This change adds fix and test for thePsrCachedReaderand also fixesCachedReaderbut without a tests since it’s deprecated.Fixes #186