Catch filemtime warning thrown as ErrorException #45740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ReflectionClass->getFileName() returns a filename with eval()'d in it, filemtime emits a warning which is thrown as an Error Exception in Symfony by default. - Related to this issue in doctrineannotations: doctrine/annotations#186
GromNaN
requested changes
Mar 15, 2022
|
Thanks for the PR. I'm closing because the right fix is doctrine/annotations#436. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Doctrine\Common\Annotations\PsrCachedReader::getLastModificationwhenReflectionClass->getFileName()returns a filename containingeval()'d, the call tofilemtimel.198 emits a warning which is thrown as an Error Exception in Symfony by default and kills the cache warming process.I found out there is an ongoing PR to address this issue directly in
doctrine/annotationsso once it's merged I guess this one will no longer be needed, just putting it here as a temporary fallback solution.doctrine/annotations