Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch filemtime warning thrown as ErrorException #1

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

maxime-aknin
Copy link
Owner

@maxime-aknin maxime-aknin commented Mar 14, 2022

In Doctrine\Common\Annotations\PsrCachedReader::getLastModification when ReflectionClass->getFileName() returns a filename containing eval()'d, the call to filemtime l.198 emits a warning which is thrown as an Error Exception in Symfony by default and kills the cache warming process.

Q A
Branch? 6.1 for features / 4.4, 5.4 or 6.0 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT

When ReflectionClass->getFileName() returns a filename with eval()'d in it, filemtime emits a warning which is thrown as an Error Exception in Symfony by default.

- Related to this issue in doctrineannotations: doctrine/annotations#186
@maxime-aknin maxime-aknin merged commit fd97168 into 5.x Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant