Support for custom purgers #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Mar 27, 2020
|
Please add some docs |
Done |
greg0ire
reviewed
Mar 27, 2020
|
Please have a look at the test suite, it fails. |
|
Still working on solving the deprecation warnings |
greg0ire
reviewed
Mar 28, 2020
|
Alright, here we are:
I guess we are ready to go Thanks for the collaboration, @greg0ire |
greg0ire
approved these changes
Mar 28, 2020
When running the suite in 1 out of 1000 times I a previous container was incorrectly reused
|
@greg0ire meditating over it a bit, I've moved more responsibilities into the factory and added a warning if a user passes an unknown purger so that we are not falling back to the default factory silently. |
|
Tested this in a project and it works. Found and fixed another bug (truncate mode was not correctly passed). |
Custom purgers can now specified by implementing a PurgerFactory and registering it with a tag "doctrine.fixtures.purger_factory" and specifying an alias. Co-Authored-By: Claudio Zizza <859964+SenseException@users.noreply.github.com>
|
@SenseException done |
SenseException
approved these changes
Apr 2, 2020
|
Thanks @lstrojny ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify a custom purger (as previously requested in #116).
As a user, I can register my custom purger factory, that implements
createForEntityManager(?string $emName, EntityManagerInterface $em, array $excluded = [], bool $purgeWithTruncate = false) : PurgerInterfacewith the tagdoctrine.fixtures.purger_factoryand somealiasand then run the command with--purger=$alias. If theORMPurgeris used--purge-exclusions, a list of tables that ought to not be purged, are supported.