Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom ORMPurger #347

Merged
merged 3 commits into from Apr 7, 2020

Conversation

kissifrot
Copy link
Contributor

@kissifrot kissifrot commented Apr 5, 2020

doctrine/DoctrineFixturesBundle#307 on Bundle-side allowed to create custom Purger, however an instance of ORMPurger is needed.
This PR allows a new ORMPurgerInterface to be used instead.

Co-Authored-By: Andreas Braun <alcaeus@users.noreply.github.com>
@kissifrot
Copy link
Contributor Author

kissifrot commented Apr 7, 2020

@alcaeus However CI complains about Interface suffix, however all other interfaces are sufixed, what should I do?

@alcaeus
Copy link
Member

alcaeus commented Apr 7, 2020

Since we can't rename the ORMPurger class, it's fine to add another exception for the new ORMPurgerInterface in phpcs.xml.dist:

<exclude-pattern>lib/Doctrine/Common/DataFixtures/Purger/PurgerInterface.php</exclude-pattern>

@kissifrot
Copy link
Contributor Author

Since we can't rename the ORMPurger class, it's fine to add another exception for the new ORMPurgerInterface in phpcs.xml.dist:

<exclude-pattern>lib/Doctrine/Common/DataFixtures/Purger/PurgerInterface.php</exclude-pattern>

Done :)

@alcaeus alcaeus merged commit 9e2a625 into doctrine:master Apr 7, 2020
@alcaeus
Copy link
Member

alcaeus commented Apr 7, 2020

Thanks @kissifrot!

@alcaeus alcaeus self-assigned this Apr 7, 2020
@alcaeus alcaeus added this to the 1.5.0 milestone Apr 7, 2020
@kissifrot kissifrot deleted the feature/allow-custom-ormpurger branch January 26, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants