Skip to content
This repository has been archived by the owner on Oct 29, 2020. It is now read-only.

Drop support for PHP < 7.1 #147

Merged
merged 5 commits into from Nov 13, 2018
Merged

Drop support for PHP < 7.1 #147

merged 5 commits into from Nov 13, 2018

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 8, 2018

This PR drops support for all PHP versions < 7.1 as they are no longer supported. PHP 7.1 is kept to be aligned to the Symfony 4 minimum requirement. Note that we will provide bugfixes for older PHP versions in the 1.3 branch if necessary.

@alcaeus alcaeus added this to the 1.4.0 milestone Nov 8, 2018
@alcaeus alcaeus self-assigned this Nov 8, 2018
@alcaeus
Copy link
Member Author

alcaeus commented Nov 8, 2018

#148 fixes build with symfony 4.2 - this will be merged to 1.3 before continuing with this PR.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@alcaeus alcaeus requested a review from fabpot November 9, 2018 06:35
Copy link

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the alignments in composer.json, the rest is 👍.

@alcaeus alcaeus force-pushed the drop-old-php branch 7 times, most recently from 8e86c3a to 730d86b Compare November 12, 2018 06:14
@alcaeus
Copy link
Member Author

alcaeus commented Nov 12, 2018

Build is stable for now, but it seems travis has the memcached extension installed on some systems and not on others - that makes things tricky. Installing via pecl failed, so I'm not sure what exactly we'll want to do here.

@alcaeus alcaeus merged commit ec4cda2 into doctrine:master Nov 13, 2018
@alcaeus alcaeus deleted the drop-old-php branch November 13, 2018 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants