Modernization - PHP 7.1, strict types, Build Stages, dropped legacy adapters etc. #122
Conversation
Run under nightly on Travis to allow failures for now.
There was a problem hiding this comment.
Not sure about those "real BC breaks" - can you explain how they are not real? Is it because riak and memcache aren't compatible with PHP 7 so technically there wouldn't be anyone running those on PHP 7?
Furthermore, if you're already doing a modernization of this scale, it might be worth switching to ::class constants and short array syntax at the same time ;)
| @@ -186,13 +171,11 @@ public function getConfigTreeBuilder() | |||
| ->append($this->addCouchbaseNode()) | |||
| ->append($this->addChainNode()) | |||
| ->append($this->addMemcachedNode()) | |||
| ->append($this->addMemcacheNode()) | |||
There was a problem hiding this comment.
Wouldn't this invalidate existing config with a memcache key?
| * | ||
| * @author Fabio B. Silva <fabio.bat.silva@gmail.com> | ||
| */ | ||
| class MemcacheDefinition extends CacheDefinition |
There was a problem hiding this comment.
Dropping a class is most definitely a BC break.
|
Although I REALLY like the idea of modernising all our packages I think we shouldn't do it on the bundles/modules (I actually believe that we should transfer them to SF/ZF organisations, but that's a different story). What I mean is that we did that kind of work on another bundle and SF team is reverting some changes to ensure compatibility with SF and I would like to avoid that kind of thing. |
|
Ping @fabpot @weaverryan is it ok to drop PHP 5 for cache-bundle or would you rather keep it (for now)? |
|
I'm fine with dropping PHP 5 as long as there is still a maintained version for bug fixed on 1.3 which would keep PHP 5 compat. |
|
Closing here - this will be introduced in multiple Mrs, starting with dropping support for PHP < 7.1 in #147. |
This PR includes bunch of changes, some of them BC break-ish:
Future scope:
Test failure under 7.2 looks like a redis extension bug. :/