Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title error when sidebar link exists with html tag #1404

Merged
merged 7 commits into from
Nov 22, 2020

Conversation

sy-records
Copy link
Member

@sy-records sy-records commented Oct 20, 2020

Summary

fix #1353 (comment) and fix #1408

image

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Oct 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/m3xtt6cxy
✅ Preview: https://docsify-preview-git-fix-sidebar.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6385b7f:

Sandbox Source
docsify-template Configuration

Koooooo-7
Koooooo-7 previously approved these changes Oct 20, 2020
@sy-records sy-records linked an issue Oct 26, 2020 that may be closed by this pull request
1 task
@sy-records sy-records changed the title fix: title error when sidebar link exists with image fix: title error when sidebar link exists with html tag Oct 26, 2020
Koooooo-7
Koooooo-7 previously approved these changes Oct 26, 2020
Copy link
Member

@jhildenbiddle jhildenbiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that the fix is working. Two minor code style change requests.

Nice work! 😄

src/core/render/tpl.js Outdated Show resolved Hide resolved
test/unit/render-util.test.js Outdated Show resolved Hide resolved
Copy link
Member

@jhildenbiddle jhildenbiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making the changes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title get wrong content Broken display URL's in headers
3 participants