Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] html in attr not escaped #1424

Closed
wants to merge 3 commits into from
Closed

[fix] html in attr not escaped #1424

wants to merge 3 commits into from

Conversation

Scrum
Copy link

@Scrum Scrum commented Nov 11, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/k94r69x3j
✅ Preview: https://docsify-preview-git-fix-html-in-attr.docsify-core.vercel.app

@Scrum Scrum changed the title Fix/html in attr [fix] html in attr not escaped Nov 11, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acbb19b:

Sandbox Source
docsify-template Configuration

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

One optional thought

src/core/render/tpl.js Show resolved Hide resolved
@sy-records
Copy link
Member

#1404 will fix this problem

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

But there are some problems:

  1. You don't need to modify package-lock.json
  2. The problem with the A tag has been fixed. fix: the sidebar links to another site. #1336
  3. The title shouldn't have any tags, so it will be removed at fix: title error when sidebar link exists with html tag #1404, not escaped.
    & " 'neither need be escaped.

@Scrum
Copy link
Author

Scrum commented Nov 12, 2020

Thank you for your contribution.

But there are some problems:

1. You don't need to modify `package-lock.json`

2. The problem with the `A` tag has been fixed. #1336

3. The `title` shouldn't have any tags, so it will be removed at #1404, not escaped.
   `& " '`neither need be escaped.

force update PR

@sy-records
Copy link
Member

Actually, I think you can close this PR :)

@Scrum Scrum closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants