Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for updating license file for dependabot branches #1517

Merged
merged 10 commits into from May 3, 2022

Conversation

kathy-t
Copy link
Contributor

@kathy-t kathy-t commented May 2, 2022

Description
This PR adds a GitHub action that is triggered on a push event for branches that begin with dependabot/, updates the license file, and pushes the changes if there are any.

From dependabot docs:

Dependabot generates a branch for each pull request. Each branch name includes dependabot, and the package manager and dependency that are updated. By default, these parts are separated by a / symbol, for example: dependabot/npm_and_yarn/next_js/acorn-6.4.1.

If you happen to create a branch that starts with dependabot/ then this action will run, but it's probably unlikely to happen since we use hubflow.

A git name and email has to be set in order to commit something. I used option 2 in this comment to display that the user who performed the commit is the GitHub Action bot.

An example of this GitHub action running is in this draft PR: #1516.

  • Note the actual commit that was done by the GitHub action.
  • You can view the actual GitHub action job here.

Issue
SEAB-4223

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool time saver, better than my idea 😄

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1517 (dc0c220) into develop (19001e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1517   +/-   ##
========================================
  Coverage    43.88%   43.88%           
========================================
  Files          312      312           
  Lines         9380     9380           
  Branches      2244     2244           
========================================
  Hits          4116     4116           
  Misses        3433     3433           
  Partials      1831     1831           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19001e8...dc0c220. Read the comment docs.

Copy link
Contributor

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I did not know you could do that.

Copy link
Member

@david4096 david4096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@kathy-t kathy-t merged commit b39d415 into develop May 3, 2022
@kathy-t kathy-t deleted the feature/seab-4223/update-licence-gh-action branch May 3, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants