Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dependabot/simulate update #5308

Closed
wants to merge 3 commits into from

Conversation

denis-yuen
Copy link
Member

Description
Auto-update based on dockstore/dockstore-ui2#1517

Review Instructions
A little tiime dependent, will probably need to wait for a dependabot PR that affects non-generated Maven files and see if it is updated with a proper license file and generated pom files

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4589

Security
n/a

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Jan 11, 2023
@denis-yuen
Copy link
Member Author

wrong branch name

@denis-yuen denis-yuen closed this Jan 11, 2023
@denis-yuen denis-yuen deleted the feature/dependabot/simulate_update branch January 11, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant