Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/danieljoos/wincred to v1.1.2 #208

Merged
merged 1 commit into from Sep 14, 2021

Conversation

crazy-max
Copy link
Member

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@thaJeztah
Copy link
Member

Looks like @aiordache may be running into the same "timeout" issue (on Windows 11), and will give this a test.

Looks like this repository was still using travis; @crazy-max do you have time to change it to a basic github action, so that we can run CI on this PR as well?

@crazy-max
Copy link
Member Author

Looks like @aiordache may be running into the same "timeout" issue (on Windows 11), and will give this a test.

Do you have a link to the issue? After further investigation on my side it looks like the desktop credsStore is the culprit. Not wincred or osxkeychain. See moby/buildkit#2313 (comment)

Looks like this repository was still using travis; @crazy-max do you have time to change it to a basic github action, so that we can run CI on this PR as well?

Sure!

@thaJeztah
Copy link
Member

Do you have a link to the issue? After further investigation on my side it looks like the desktop credsStore is the culprit. Not wincred or osxkeychain. See moby/buildkit#2313 (comment)

Oh! I saw your comment, but didn't understand what you meant. Got it now!

As far as I know, desktop credsStore is the same as wincred, just a different name for the binary (not sure why that was done, but perhaps it was to prevent conflicts with users installing wincred? perhaps @ebriney knows

@crazy-max
Copy link
Member Author

PTAL @ebriney @aiordache @djs55

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ebriney ebriney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants