go.mod: update docker-credential-helpers v0.7.0 #9936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
update_deps
branch
from
b607233
to
0667555
Compare
Codecov ReportBase: 74.56% // Head: 74.56% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #9936 +/- ##
=======================================
Coverage 74.56% 74.56%
=======================================
Files 2 2
Lines 232 232
=======================================
Hits 173 173
Misses 51 51
Partials 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
let me rebase |
The file had multiple "requires" blocks, which made it harder to find which dependencies were used. Some direct modules also were in the "indirect" block. While updating, also updated some comments. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
BuildKit and Buildx no longer require this replace rule (it probably only was needed in buildkit, which used this version to compile). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by the cli (the cli doesn't use go.mod, so go modules doesn't automatically pick that up); https://github.com/docker/cli/blob/1d6c6e2367e292950e483e3c8ace142792bca718/vendor.mod#L14 Used code doesn't change, but we want to keep the older github.com/danieljoos/wincred v1.1.0 out of the dependency tree :) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
update_deps
branch
from
0667555
to
c630c8d
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mod: update docker-credential-helpers v0.7.0
to match the version used by the cli (the cli doesn't use go.mod, so go modules
doesn't automatically pick that up);
https://github.com/docker/cli/blob/1d6c6e2367e292950e483e3c8ace142792bca718/vendor.mod#L14
Used code doesn't change, but we want to keep the older github.com/danieljoos/wincred v1.1.0
out of the dependency tree :)
Other changes:
go mod: tidy and group "require" blocks, update comments
The file had multiple "requires" blocks, which made it harder to find which
dependencies were used. Some direct modules also were in the "indirect" block.
go.mod: remove replace for runc
BuildKit and Buildx no longer require this replace rule (it probably only was
needed in buildkit, which used this version to compile).
What I did
Related issue
golang.org/x/sysdanieljoos/wincred#22(not mandatory) A picture of a cute animal, if possible in relation with what you did