update to compose-go v1.4.0 as previous version introduced breaking changes #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
ndeloof
approved these changes
Aug 1, 2022
|
I am having some trouble with the updated compose version 2.9.0 where this fix should be applied. Using the following example dockerfile to demonstrate the issue: FROM docker:latest
RUN mkdir /app
WORKDIR /app
ENV BUILDKIT_PROGRESS=plain
RUN echo -e "\
services:\n\
example:\n\
build:\n\
context: .\n\
dockerfile: Dockerfile\n\
command: -text="hello world"\n\
" > docker-compose.yml
RUN echo -e "\
FROM hashicorp/http-echo\n\
ENV FOO=BAR" > Dockerfile
RUN echo -e "\
docker-compose --version \n\
docker compose version \n\
docker compose build \n\
docker-compose build" > /cmd.sh && chmod +x /cmd.sh
CMD ["/cmd.sh"]And building/running it with: I am observing the following (truncated) output: E.g. the separator used is still However when I run the same image with the Is there something I am doing wrong? Note: I don't think the issue is with the official docker image as I am observing a similar behavior with compose v2.9.0 on my arch linux installation. |
|
I can also open a new issue about this if needed. |
|
Hi @Jyrno42 |
|
Oh, OK. Thanks for the clarifications. Then I know its safe to update my scripts without fearing a revert there. |
ThorgateDeveloper
pushed a commit
to thorgate/django-project-template
that referenced
this pull request
Aug 5, 2022
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
ThorgateDeveloper
pushed a commit
to thorgate/django-project-template
that referenced
this pull request
Aug 5, 2022
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
This was referenced Aug 11, 2022
IncrePrior
added a commit
to IncrePrior/django-project-template
that referenced
this pull request
Nov 12, 2023
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours guillaume.lours@docker.com
What I did
Bump version of compose-go to
v1.4.0which remove the breaking changes introduced in versionv1.3.0by this PR(not mandatory) A picture of a cute animal, if possible in relation with what you did
