New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert usage of "-" as separator for resource names #297
Conversation
ed7dcc9
to
2c4d6cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
while mix of dash and underscore can create some confusion, the benefit is poor regarding the backward compatibility impact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also pinging here for more visibility. I am having some trouble with the updated compose version 2.9.0 where this fix should be applied. Essentially the separator still seems to be see more context and a repro case here docker/compose#9700 (comment) E: Turns out that I was just confused. The revertion was done only for related resources like networks, volumes, secrets and config. The container names will be using |
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
As noticed by some users in the original PR, the changes were breaking ones and unjustified regarding the value offered in counter part.
This reverts commit 56e6c33, reversing
changes made to 0ab97a2.