Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DistDGL tools] Remove restriction on partition algorithm name #7361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DistDGL tools] Remove restriction on partition algorithm name #7361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions tools/partition_algo/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,5 @@ def load_partition_meta(meta_file):
raise DGLError(
f"num_parts[{part_meta.num_parts}] should be greater than 0."
)
if part_meta.algo_name not in ["random", "metis"]:
raise DGLError(
f"algo_name[{part_meta.num_parts}] is not supported."
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think partition/assignment algo is part of the whole distributed partition pipeline, so it's better to check the algo name to make sure the target algo is really supported(that means well tested by pipeline provider). Add a new one named range is preferable.

return part_meta