Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DistDGL tools] Remove restriction on partition algorithm name #7361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thvasilo
Copy link
Contributor

Description

Since partition assignment algorithms are independent of DGL, there shouldn't be a restriction on the name of the partition algorithm.

For GraphStorm we have implemented a range partition algorithm, and would like to provide the correct name in the metadata file.

@Rhett-Ying for review

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Since partition assignment algorithms are independent of DGL, there shouldn't be a restriction on the name of the partition algorithm.

For GraphStorm we have implemented a range partition algorithm, and would like to provide the correct name in the metadata file.
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 26, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 26, 2024

Commit ID: 520e9ee

Build ID: 1

Status: ❌ CI test failed in Stage [CPU Build (Win64)].

Report path: link

Full logs path: link

raise DGLError(
f"algo_name[{part_meta.num_parts}] is not supported."
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think partition/assignment algo is part of the whole distributed partition pipeline, so it's better to check the algo name to make sure the target algo is really supported(that means well tested by pipeline provider). Add a new one named range is preferable.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 28, 2024

Commit ID: 520e9ee

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants