Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SOCK_NONBLOCK from socket creation on tests #321

Merged
merged 4 commits into from Apr 1, 2022
Merged

Remove SOCK_NONBLOCK from socket creation on tests #321

merged 4 commits into from Apr 1, 2022

Conversation

ereslibre
Copy link
Contributor

This fixes running tests on Mac OS X, which lacks the SOCK_NONBLOCK
socket flag creation.

This fixes running tests on Mac OS X, which lacks the `SOCK_NONBLOCK`
socket flag creation.
@andrewgodwin
Copy link
Member

I wish I could remember why it was there in the first place, but I can't think of a good reason and the tests seem to pass, so... sure?

You'll need to pin the version of Click to fix that linting error for now though - see psf/black#2964

@ereslibre
Copy link
Contributor Author

@andrewgodwin I'm sorry I don't know what's the most appropriate way to pin click, not familiar with python/django development, and I don't see a conclusive way to do so out of the box. A pointer will do, thanks!

@Kludex
Copy link
Contributor

Kludex commented Apr 1, 2022

Here:

asgiref/setup.cfg

Lines 37 to 41 in cde961b

[options.extras_require]
tests =
pytest
pytest-asyncio
mypy>=0.800

Add click==<version_that_works>

Due to an incompatibility with black linter, pin click to 8.0.4:
psf/black#2964
@ereslibre
Copy link
Contributor Author

Thank you @Kludex. Done.

@andrewgodwin
Copy link
Member

Looks like I got it wrong there - it was the pre-commit hook that needed fixing! I've made the changes for you - thanks for the PR!

@andrewgodwin andrewgodwin merged commit d451a72 into django:main Apr 1, 2022
@ereslibre
Copy link
Contributor Author

That was my first try, but I did undo it just because I didn't know if it was what you wanted :)

Thanks for the reviews!

@ereslibre ereslibre deleted the remove-sock-nonblock branch April 1, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants