Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SOCK_NONBLOCK from socket creation on tests #321

Merged
merged 4 commits into from Apr 1, 2022
Merged

Remove SOCK_NONBLOCK from socket creation on tests #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31541da
Remove `SOCK_NONBLOCK` from socket creation on tests
ereslibre Mar 31, 2022
e413852
Pin click test dependency to 8.0.4
ereslibre Apr 1, 2022
5a3c3f5
Remove Click fix in setup.cfg
andrewgodwin Apr 1, 2022
f68e174
Updating Black pre-commit hook
andrewgodwin Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ repos:
args: ["--py37-plus"]

- repo: https://github.com/psf/black
rev: 20.8b1
rev: 22.3.0
hooks:
- id: black
args: ["--target-version=py37"]
Expand Down
6 changes: 4 additions & 2 deletions tests/test_server.py
View file
Open in desktop
Expand Up @@ -21,7 +21,8 @@ def __init__(self, application, max_applications=1000):
application,
max_applications=max_applications,
)
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM | sock.SOCK_NONBLOCK)
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM)
self._sock.setblocking(False)
self._sock.bind(("127.0.0.1", 0))

@property
Expand Down Expand Up @@ -54,7 +55,8 @@ def close(self):

class Client:
def __init__(self, name):
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM | sock.SOCK_NONBLOCK)
self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM)
self._sock.setblocking(False)
self.name = name

async def register(self, server_addr, name=None):
Expand Down