Add/fix darwin support for various virt-manager dependencies

[mikroskeem]

Motivation for this change

I am planning to get virt-manager up and running on Darwin.

Supersedes bunch of changes in stale-ish PRs:

• virt-manager: support building on darwin #113306
• WIP: virt-manager: enable aarch64-darwin #128767

Depends on:

• libpulseaudio: fix aarch64-darwin build #152371

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[mikroskeem]

All actions have consequences, this PR won't avoid them either. Will add additional fixes reported by nixpkgs-review pr 152348.

Right now I'm seeing gtkd -> libgda -> gcc6, which is not going to work out.

[mikroskeem]

Seems like 133b961 broke GTK-3 on aarch64-darwin.

[mikroskeem]

After ~8 hours of building... never going to do staging branch builds on my laptop ever again lol.

EDIT: shouldn't be that bad anymore, I split libgda to separate PR.

Result of nixpkgs-review pr 152348 run on aarch64-darwin 1

13 packages built:

• geany-with-vte
• germinal
• gtk-vnc
• gtkd
• libgda
• libosinfo
• libvirt-glib
• osinfo-db
• osinfo-db-tools
• spice-gtk
• termite (termite-unwrapped)
• usbredir
• vte

[mikroskeem]

@NixOS/darwin-maintainers

[toonn]

Hmm, nixpkgs-review failed for me:

building '/nix/store/53jl7cn13wk51b42wxbgyqkm8v6m620s-bootstrap-stage2-stdenv-darwin.drv'...
building '/nix/store/x3pmi0qp8bbj07ynpr125h0cvfysvnsg-bootstrap-stage2-stdenv-darwin.drv'...
error: output '/nix/store/kknyif7z0py8h6gybp47fdzp5dgib90h-bootstrap-stage2-stdenv-darwin' is not allowed to refer to the following paths:
         /nix/store/5p5pncjap0kax6jzsh5jxq2nz5h75b7y-zstd-1.5.1
         /nix/store/m4vzwxx1qvvbpslisljzz35xx0n5ay3w-libunistring-0.9.10
         /nix/store/x7x5s166m6dn6vanr0zcwm9pkrprvsbg-libidn2-2.3.2
error: output '/nix/store/ynngj9vlnl6q5bd5v63yrhpvx4vwq48n-bootstrap-stage2-stdenv-darwin' is not allowed to refer to the following paths:
         /nix/store/5p5pncjap0kax6jzsh5jxq2nz5h75b7y-zstd-1.5.1
         /nix/store/m4vzwxx1qvvbpslisljzz35xx0n5ay3w-libunistring-0.9.10
         /nix/store/x7x5s166m6dn6vanr0zcwm9pkrprvsbg-libidn2-2.3.2
error: 1 dependencies of derivation '/nix/store/q7ypyd32hdss0637v51vb4dp3l1mbm81-adv_cmds-119.drv' failed to build
error: 1 dependencies of derivation '/nix/store/sf98rj1zplhwghc7a370xhdgq8f9pxbg-bash-5.1-p12.drv' failed to build
error: build of '/nix/store/48frjw3q6fdpf4wfzi1d944ypxa8whx9-stdenv-darwin.drv', '/nix/store/i21njz3vb4ljfh84mj26a4giidawhg75-bash-interactive-5.1-p12.drv', '/nix/store/sf98rj1zplhwghc7a370xhdgq8f9pxbg-bash-5.1-p12.drv' failed
$ git worktree prune

However, @alyssais mentioned in the Darwin room that Darwin stdenv is broken on staging so this may (I suspect it is) just be a consequence of that.

[alyssais]

Yeah, that's the same error I saw for other PRs.

[mikroskeem]

Bump

[uri-canva]

Running the build on my laptops, so far so good, but it's going to take a while.

[uri-canva]

x86_64-darwin running Monterey completed:

error: builder for '/nix/store/hywwzznlra216pfyyyawp92zg1yphq99-libxkbcommon-1.3.1.drv' failed with exit code 1;
       last 10 log lines:
       > Expected Fail:      0
       > Fail:               1
       > Unexpected Pass:    0
       > Skipped:            1
       > Timeout:            0
       >
       > Full log written to /private/tmp/nix-build-libxkbcommon-1.3.1.drv-0/libxkbcommon-1.3.1/build/meson-logs/testlog.txt
       > FAILED: meson-test
       > /nix/store/1mmpb3lm7zpi7fs9qmcdkycdqhgq6zpa-meson-0.60.3/bin/meson test --no-rebuild --print-errorlogs
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/hywwzznlra216pfyyyawp92zg1yphq99-libxkbcommon-1.3.1.drv'.
error: builder for '/nix/store/snydhfkdazvb2wsgzc0lmwmiavsh6v54-orc-0.4.32.drv' failed with exit code 1;
       last 10 log lines:
       > Expected Fail:      0
       > Fail:               0
       > Unexpected Pass:    0
       > Skipped:            0
       > Timeout:            1
       >
       > Full log written to /private/tmp/nix-build-orc-0.4.32.drv-0/orc-0.4.32/build/meson-logs/testlog.txt
       > FAILED: meson-test
       > /nix/store/1mmpb3lm7zpi7fs9qmcdkycdqhgq6zpa-meson-0.60.3/bin/meson test --no-rebuild --print-errorlogs
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/snydhfkdazvb2wsgzc0lmwmiavsh6v54-orc-0.4.32.drv'.
error: builder for '/nix/store/w4fc7fs9pqgb6l864i80wpxrmc0kdhz6-graphite2-1.3.14.drv' failed with exit code 2;
       last 10 log lines:
       > 84/84 Test #84: vm-test-direct-threading .........   Passed    5.30 sec
       >
       > 99% tests passed, 1 tests failed out of 84
       >
       > Total Test time (real) =   7.12 sec
       >
       > The following tests FAILED:
       >      80 - nametabletest (Timeout)
       > Errors while running CTest
       > make: *** [Makefile:71: test] Error 8
       For full logs, run 'nix log /nix/store/w4fc7fs9pqgb6l864i80wpxrmc0kdhz6-graphite2-1.3.14.drv'.
error: 1 dependencies of derivation '/nix/store/3d07x3qyk5avx9pf7qszfyc7di62mrm3-harfbuzz-3.2.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/cq1mhn2slsyk4hwqxamdrrzd2xl5wn41-harfbuzz-3.2.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/w12n5r4yjv60l14g3k7cy1d4yb691dfm-libass-0.15.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/aqm543njn1vcvqi1fxn5q4ggrw0jk79h-pango-1.50.3.drv' failed to build
error: 2 dependencies of derivation '/nix/store/ddqd8ny5xyaclxxp5cdzxd6b70lcklck-gtk+3-3.24.31.drv' failed to build
error: 1 dependencies of derivation '/nix/store/fzr1zyzm51d5xivhahgi9v7hm4yj5x9p-appstream-glib-0.7.18.drv' failed to build
error: 2 dependencies of derivation '/nix/store/a6z2y26si15v0xbrbm97j1gxafmilmcl-gtksourceview-4.8.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/82cgyxbc0jxm4r45rg2mxg887bd9aydp-libgda-5.2.10.drv' failed to build
error: 1 dependencies of derivation '/nix/store/7vf5yrrzsy33nk12a512xppml4l5bx6r-libpeas-1.30.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/mf392gy6xz8km9fplvx4hbipzjlbljhp-vte-0.64.2.drv' failed to build
error: 2 dependencies of derivation '/nix/store/qpb8hn5g981shyq0vx6zhl7i4z2w2k7i-vte-0.64.2.drv' failed to build
error: 2 dependencies of derivation '/nix/store/47v22hhjl6gw9barqp1ky37vm3rk204s-gst-plugins-base-1.18.5.drv' failed to build
error: 2 dependencies of derivation '/nix/store/8xrhx7gl71xc61qfn09ffzgjidmbjd3q-gst-plugins-good-1.18.5.drv' failed to build
error: 3 dependencies of derivation '/nix/store/wpwyy224aph2pp5rkp12xq0lnfh2q664-spice-gtk-0.37.drv' failed to build
error: 1 dependencies of derivation '/nix/store/cr5yvr22c65836qjk2zfca3lc6i0gswn-gtk-vnc-1.3.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/kxn00fi9rffaadx8zdhnbf9xcvqrqy5j-ffmpeg-4.4.1.drv' failed to build
error: 2 dependencies of derivation '/nix/store/qzfx6mnf6zg9sblsczdhn56zhz400f9y-opencv-4.5.4.drv' failed to build
error: 1 dependencies of derivation '/nix/store/8swp13fv34bs6r7myp3i60x9nmrl9yqc-librsvg-2.52.4.drv' failed to build
error: 6 dependencies of derivation '/nix/store/9rly96nb7bxy6kc06wgszcd5bwslmrfn-gst-plugins-bad-1.18.5.drv' failed to build
error: 2 dependencies of derivation '/nix/store/zd2czd7z34bz3b287pbrfnfpfpm4ad7y-hook.drv' failed to build
error: 4 dependencies of derivation '/nix/store/jkxkmi7pl5y18pq57xl4wnx3ynzw6p6z-germinal-26.drv' failed to build
error: 9 dependencies of derivation '/nix/store/i4ill45ha4cd5163n66p13s2p745q32j-gtkd-3.9.0.drv' failed to build
error: 3 dependencies of derivation '/nix/store/naqfy3iagfqbpw6z25bh74irl5a30ckg-termite-15.drv' failed to build
error: 6 dependencies of derivation '/nix/store/45fz9035rw0bv1sr2cfdqbck4d3504bv-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/152348

2 packages marked as broken and skipped:
mate.mate-terminal virt-manager-qt

6 packages failed to build:
germinal gtk-vnc gtkd spice-gtk termite vte

5 packages built:
libosinfo libvirt-glib osinfo-db osinfo-db-tools usbredir

error: build log of '/nix/store/jkxkmi7pl5y18pq57xl4wnx3ynzw6p6z-germinal-26.drv' is not available
error: build log of '/nix/store/xmml809msi8i27gsq230aq5qn60ibc10-germinal-26' is not available
error: build log of '/nix/store/cr5yvr22c65836qjk2zfca3lc6i0gswn-gtk-vnc-1.3.0.drv' is not available
error: build log of '/nix/store/1if87v487jg7f7yxcisz25y1mij63mzk-gtk-vnc-1.3.0' is not available
error: build log of '/nix/store/i4ill45ha4cd5163n66p13s2p745q32j-gtkd-3.9.0.drv' is not available
error: build log of '/nix/store/h555irl2yqzmgr1j06lhpj06345hd8vc-gtkd-3.9.0' is not available

[uri-canva]

I disabled the tests for the three packages that were failing: libxkbcommon, orc and graphite2 and the remaining packages built correctly. The build on the M1 laptop is still going.

[ereslibre]

Note: ereslibre@7a6d674 included patch is not up to date. The commit that made it into the asgiref project was django/asgiref@d451a72. This is the commit that will be included sometime in asgiref 3.5.1 when it's tagged.

[mikroskeem]

I give up

[ereslibre]

I give up

Thanks @mikroskeem for all your efforts. Really appreciated.