Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round prices to two decimal places in price comparison check in basket #4221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Round prices to two decimal places in price comparison check in basket #4221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/oscar/apps/basket/abstract_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ def get_warning(self):

# Compare current price to price when added to basket
current_price_incl_tax = self.purchase_info.price.incl_tax
if current_price_incl_tax != self.price_incl_tax:
if round(current_price_incl_tax, 2) != round(self.price_incl_tax, 2):
product_prices = {
"product": self.product.get_title(),
"old_price": currency(self.price_incl_tax, self.price_currency),
Expand Down