Round prices to two decimal places in price comparison check in basket #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix price comparison by rounding to two decimal places, preventing misleading cart notifications when prices are effectively the same. Previously, the comparison between these two prices was done directly, which caused issues when the number of decimal places differed.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4221 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 291 291
Lines 16145 16145
=======================================
Hits 14177 14177
Misses 1968 1968
|
|
@fortelll please use round_half_up like everywhere else in the basket. Could you please add a test that shows this failed before? |
viggo-devries
added
the
Needs tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed price comparison by rounding to two decimal places, preventing misleading cart notifications when prices are effectively the same. Previously, the comparison between these two prices was done directly, which caused issues when the number of decimal places differed.