Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt wording and translations #681

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Adapt wording and translations #681

wants to merge 6 commits into from

Conversation

codingjoe
Copy link
Collaborator

@codingjoe codingjoe commented Apr 29, 2024

Friends, can you please help me with the translations here?
I used AI, but translating short words without context to another language usually yields poor results. I appreciate your support 🙏 Just leave your suggestions in the review comments.

@amureki
@mostafa-anm
@adrian
@Kumamoto-Hamachi
@Stormheg
@zopieux
@lucasgarciaaraujo
@VerosK

@codingjoe codingjoe self-assigned this Apr 29, 2024
hijack/contrib/admin/admin.py Show resolved Hide resolved
hijack/locale/ru/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/ru/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/ru/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/ru/LC_MESSAGES/django.po Show resolved Hide resolved
hijack/locale/ru/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
Co-authored-by: Alexandr Artemyev <mogost@gmail.com>
Copy link
Contributor

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting effort in this @codingjoe

The Dutch translations definitely warranted some human attention 😄

hijack/locale/nl/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/nl/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/nl/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/ru/LC_MESSAGES/django.po Show resolved Hide resolved
hijack/locale/fr/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/fr/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
Copy link
Contributor

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Russian translation makes sense to me. 👍

Copy link
Contributor

@zopieux zopieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translation LGTM except for two comments I left.

Copy link
Contributor

@Kumamoto-Hamachi Kumamoto-Hamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the Japanese translation! I left three comments.

hijack/locale/ja/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/ja/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/ja/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
codingjoe and others added 2 commits May 3, 2024 14:27
Co-authored-by: Alexandr Artemyev <mogost@gmail.com>
Co-authored-by: Storm Heg <storm@stormbase.digital>
@codingjoe
Copy link
Collaborator Author

Thanks, everyone! I greatly appreciate your effort and support here. I followed your advice and made the action buttons on the banner more verbose. Please help me out one last time to nail their respective translations.

Copy link
Contributor

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks, after that LGTM

hijack/locale/nl/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
hijack/locale/nl/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
Co-authored-by: Storm Heg <storm@stormbase.digital>
@codingjoe codingjoe marked this pull request as ready for review May 4, 2024 08:51
Copy link
Contributor

@Kumamoto-Hamachi Kumamoto-Hamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the commit fixing the Japanese translation! LGTM

msgstr "освободить"
#: templates/hijack/notification.html:19
msgid "stop impersonating"
msgstr "перестаньте выдавать себя за человека"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "перестаньте выдавать себя за человека"
msgstr "перестать притворяться"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants