fix admin logout bug

README.rst

@@ -111,6 +111,9 @@ Optional settings include:
 * ``CAS_LOGIN_URL_NAME``: Name of the login url, defaults to ``'cas_ng_login'``.
   This is only necessary if you use the middleware and want to use some other
   name for the login url (e.g. ``'my_app:cas_login'``).
+* ``CAS_LOGOUT_URL_NAME``: Name of the logout url, defaults to
+  ``'cas_ng_logout'``. This is only necessary if you use the middleware and
+  want to use some other name for the logout url (e.g. ``'my_app:cas_logout'``).
 * ``CAS_EXTRA_LOGIN_PARAMS``: Extra URL parameters to add to the login URL
   when redirecting the user. Example::
 
@@ -194,8 +197,9 @@ and later:
     ]
 
 
-If you use the middleware, the ``login`` url must be given the name ``cas_ng_login``
-or it will create redirection issues, unless you set the ``CAS_LOGIN_URL_NAME`` setting.
+If you use the middleware, the ``login`` and ``logout`` url must be given the
+name ``cas_ng_login`` and ``cas_ng_logout`` or it will create redirection
+issues, unless you set the ``CAS_LOGIN_URL_NAME`` and ``CAS_LOGOUT_URL_NAME`` setting.
 
 You should also add an URL mapping for the ``CAS_PROXY_CALLBACK`` setting, if you have this
 configured:

django_cas_ng/__init__.py

@@ -11,6 +11,7 @@
     'CAS_ADMIN_PREFIX': None,
     'CAS_CREATE_USER': True,
     'CAS_LOGIN_URL_NAME': 'cas_ng_login',
+    'CAS_LOGOUT_URL_NAME': 'cas_ng_logout',
     'CAS_EXTRA_LOGIN_PARAMS': None,
     'CAS_RENEW': False,
     'CAS_IGNORE_REFERER': False,

django_cas_ng/middleware.py

@@ -49,6 +49,9 @@ def process_view(self, request, view_func, view_args, view_kwargs):
         elif not view_func.__module__.startswith('django.contrib.admin.'):
             return None
 
+        if view_func.__name__ == 'logout':
+            return HttpResponseRedirect(reverse(settings.CAS_LOGOUT_URL_NAME))
+
         if request.user.is_authenticated:
             if request.user.is_staff:
                 return None

tests/test_backend.py

@@ -389,7 +389,7 @@ def mock_verify(ticket, service):
             request, ticket='fake-ticket', service='fake-service',
         )
 
-    assert "CAS_CREATE_USER_WITH_ID is True, but `'id'` is not part of attributes." in str(excinfo)
+    assert "CAS_CREATE_USER_WITH_ID is True, but `'id'` is not part of attributes." in str(excinfo.value)
 
 
 @pytest.mark.django_db
@@ -420,7 +420,7 @@ def mock_verify(ticket, service):
             request, ticket='fake-ticket', service='fake-service',
         )
 
-    assert "CAS_CREATE_USER_WITH_ID is True, but no attributes were provided" in str(excinfo)
+    assert "CAS_CREATE_USER_WITH_ID is True, but no attributes were provided" in str(excinfo.value)
 
 
 @pytest.mark.django_db