Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix admin logout bug #211

Merged
merged 3 commits into from Aug 26, 2019
Merged

Conversation

leavest
Copy link
Contributor

@leavest leavest commented Jul 2, 2019

@mingchen
Copy link
Collaborator

mingchen commented Jul 2, 2019

Can you fix the failed test ?

@leavest
Copy link
Contributor Author

leavest commented Jul 3, 2019

Can you fix the failed test ?

it is the problem for the test case.
in test_backend.py line 387

    with pytest.raises(ImproperlyConfigured) as excinfo:
        user = backend.authenticate(
            request, ticket='fake-ticket', service='fake-service',
        )

    assert "CAS_CREATE_USER_WITH_ID is True, but `'id'` is not part of attributes." in str(excinfo)

see pytest-dev/pytest#5413.
in newest pytest, str(excinfo) returrn ExceptionInfo.repr_(), like <ExceptionInfo ImproperlyConfigured tblen=3>
but not error value for Exception, like "CAS_CREATE_USER_WITH_ID is True, but `'id'` is not part of attributes."

@mingchen mingchen merged commit 57bcf33 into django-cas-ng:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants