FEATURE: Add cops for plugins #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flink
force-pushed
the
loic-plugins-rules
branch
from
f7c923d
to
6717fd4
Compare
Flink
force-pushed
the
loic-plugins-rules
branch
from
d40efb1
to
7309893
Compare
Flink
changed the title
nbianca
reviewed
Feb 26, 2024
nbianca
approved these changes
Feb 26, 2024
Flink
force-pushed
the
loic-plugins-rules
branch
from
7309893
to
00b5b35
Compare
This patch adds some new rules to have saner defaults for our plugins. These rules should help in particular with disabled plugins. The new cops are: * Discourse/Plugins/CallRequiresPlugin: checks `requires_plugin` is called in controllers. * Discourse/Plugins/DiscourseEvent: checks `on` is called instead of `DiscourseEvent.on`. * Discourse/Plugins/NamespaceConstants: checks constants are not defined outside the plugin namespace. * Discourse/Plugins/NamespaceMethods: checks methods are not defined outside the plugin namespace. * Discourse/Plugins/NoMonkeyPatching: checks existing classes are not patched in `plugin.rb` using `class_eval`. * Discourse/Plugins/UseRequireRelative: checks `load` is not used to load dependencies.
Flink
force-pushed
the
loic-plugins-rules
branch
from
00b5b35
to
0b1e14b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds some new rules to have saner defaults for our plugins. These rules should help in particular with disabled plugins.
The new cops are:
requires_pluginis called in controllers.onis called instead ofDiscourseEvent.on.plugin.rbusingclass_eval.loadis not used to load dependencies.