Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update rubocop-discourse to latest version #25524

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Flink
Copy link
Contributor

@Flink Flink commented Feb 1, 2024

The lastest version of rubocop-discourse enables rules regarding plugins.

Related PR: discourse/rubocop-discourse#41

@Flink Flink self-assigned this Feb 1, 2024
@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Feb 5, 2024
@Flink Flink force-pushed the loic-rubocop-plugin-rules branch 3 times, most recently from 811e65a to 0f3c0df Compare February 12, 2024 16:36
@Flink Flink force-pushed the loic-rubocop-plugin-rules branch 2 times, most recently from f7d3142 to 95ce47d Compare February 13, 2024 13:05
@Flink Flink force-pushed the loic-rubocop-plugin-rules branch 2 times, most recently from dc69db5 to 08853f6 Compare February 26, 2024 15:43
@Flink Flink marked this pull request as ready for review February 26, 2024 15:46
Gemfile Outdated Show resolved Hide resolved
@nbianca
Copy link
Member

nbianca commented Feb 26, 2024

I think something else changed with Rubocop because the lint stage is failing. 🤔

@Flink
Copy link
Contributor Author

Flink commented Feb 27, 2024

I think something else changed with Rubocop because the lint stage is failing. 🤔

Yes, we have a new rule about fab! which hasn’t been applied yet it seems.

@Flink Flink force-pushed the loic-rubocop-plugin-rules branch 2 times, most recently from 518fd22 to 9f1acb9 Compare February 28, 2024 16:54
@Flink
Copy link
Contributor Author

Flink commented Feb 28, 2024

@nbianca Updated, everything’s green now! 🙂

The lastest version of rubocop-discourse enables rules regarding
plugins.
@Flink Flink force-pushed the loic-rubocop-plugin-rules branch from c695504 to 372d65f Compare March 4, 2024 13:54
@Flink Flink merged commit f7d7092 into main Mar 4, 2024
16 checks passed
@Flink Flink deleted the loic-rubocop-plugin-rules branch March 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat PRs which include a change to Chat plugin
3 participants