Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't error when trying to write a message to a closed client take 2 #339

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Don't error when trying to write a message to a closed client take 2 #339

merged 1 commit into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. Don't error when trying to write a message to a closed client take 2 

    This was first introduced in a2a46fd
but reverted because a new MessageBus release broke production and we
had to quickly revert before being able to isolate the commit. We have
since tested this commit in isolation in production and confirm that
MessageBus continues to work.

When a client is set to use chunked encoding by setting `use_chunked` to
true, trying to write a message to the client when the client has been
closed will raise an error. This commit changes it such that we don't
raise an error since the raised error doesn't do anything useful.
    @tgxworld
    tgxworld committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    bf52fa3 View commit details
    Browse the repository at this point in the history