Don't error when trying to write a message to a closed client take 2 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was first introduced in a2a46fd but reverted because a new MessageBus release broke production and we had to quickly revert before being able to isolate the commit. We have since tested this commit in isolation in production and confirm that MessageBus continues to work. When a client is set to use chunked encoding by setting `use_chunked` to true, trying to write a message to the client when the client has been closed will raise an error. This commit changes it such that we don't raise an error since the raised error doesn't do anything useful.
martin-brennan
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was first introduced in a2a46fd
but reverted because a new MessageBus release broke production and we
had to quickly revert before being able to isolate the commit. We have
since tested this commit in isolation in production and confirm that
MessageBus continues to work.
When a client is set to use chunked encoding by setting
use_chunkedtotrue, trying to write a message to the client when the client has been
closed will raise an error. This commit changes it such that we don't
raise an error since the raised error doesn't do anything useful.