Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting work on Issue #487 #544

Closed
wants to merge 31 commits into from
Closed

Starting work on Issue #487 #544

wants to merge 31 commits into from

Conversation

adamnemecek
Copy link
Contributor

@adamnemecek
added dq files
35ff32d
@adamnemecek
doesn't compile, copies all quaternion files -> dual quaternion
d8b4545
@adamnemecek
copies and renamed quaternions, one by one add traits
546ce93
@adamnemecek
adding stuff
ce949a2
@adamnemecek
stuff
98ae9b5
@adamnemecek
dualquaternion clone
dfd56b0
@adamnemecek
added Quaternion accessors for r,i,j,k, refactored conjugate to use imag
2b68ddc
@adamnemecek
Merge https://github.com/adamnemecek/nalgebra
5e6eccf
@adamnemecek
added Quaternion accessors for r,i,j,k, refactored conjugate to use imag
ac8a44b
@adamnemecek
added quaternionic sin and cos
8131baa
@adamnemecek
fixed whitespace
55c643d
@adamnemecek
fixed whitespace
2c4fab0
@adamnemecek
resolved merge
c7d21b4
@adamnemecek
removed extra line
21d7cde
@adamnemecek
Merge branch 'master' of https://github.com/rustsim/nalgebra into tra…
aae57b2 
…nscendentals3
@adamnemecek
stuff
ee85e4c
@adamnemecek
merged
889424c
@adamnemecek
working on tan + arctan
0bc5601
@adamnemecek
fixed tan
f5605a6
@adamnemecek
is_pure, pure, construct from pure
8a63d91
@adamnemecek
refactoring quaternion
74f601e
@adamnemecek
working on hyperbolic trig functions
ecddaf2
@adamnemecek
stuff
fe44b40
@adamnemecek
cosv2
3cc4c91
@adamnemecek
use imag constructor
ba1f8a9
@adamnemecek
cosh
39fb58d
@adamnemecek
stuff
876aabd
@adamnemecek
atanh
63ca6d4
@adamnemecek
stuff
4750232
@adamnemecek
stuff
4264c87
@Nivek92
Copy link

Nivek92 commented Sep 19, 2020

What happened to this?

@miakramer
Copy link

I checked out the code out of curiosity, it looks like it's not compiling at the moment (but nearly all of the dual quaterinon-related code is commented out anyway). The error is coming from base/cg.rs though, so I'm not sure why that is. It's a borrow checker error but I can't recall any changes in borrowck in the last year that would have changed it?

@chinedufn
Copy link
Contributor

See #810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamnemecek @Nivek92 @miakramer @chinedufn